Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CMAKE_PREFIX_PATH in imkl easyblock #3021

Merged

Conversation

SebastianAchilles
Copy link
Member

(created using eb --new-pr)
CMake does by default not search within the prefix path recursively. This PR sets the $CMAKE_PREFIX_PATH correctly to self.mkl_basedir.

@SebastianAchilles
Copy link
Member Author

Test report by @SebastianAchilles

Overview of tested easyconfigs (in order)

  • SUCCESS imkl-2021.4.0.eb
  • SUCCESS imkl-2022.0.1.eb
  • SUCCESS imkl-2022.1.0.eb
  • SUCCESS imkl-2022.2.0.eb
  • SUCCESS imkl-2022.2.1.eb
  • SUCCESS imkl-2023.0.0.eb
  • SUCCESS imkl-2023.1.0.eb

Build succeeded for 7 out of 7 (7 easyconfigs in total)
bwd-rockylinux-92 - Linux Rocky Linux 9.2 (Blue Onyx), x86_64, Intel(R) Core(TM) i7-6900K CPU @ 3.20GHz (broadwell), 2 x NVIDIA NVIDIA GeForce GTX 1060 6GB, 535.104.12, Python 3.9.16
See https://gist.github.com/SebastianAchilles/027fb1dc131b817e5f273e40c1ae5c63 for a full test report.

@SebastianAchilles
Copy link
Member Author

@boegelbot please test @ generoso
EB_ARGS="imkl-2021.4.0.eb imkl-2022.0.1.eb imkl-2022.1.0.eb imkl-2022.2.0.eb imkl-2022.2.1.eb imkl-2023.0.0.eb imkl-2023.1.0.eb --module-only --installpath /tmp/$USER/pr3021"

@boegelbot
Copy link

@SebastianAchilles: Request for testing this PR well received on login1

PR test command 'EB_PR=3021 EB_ARGS="imkl-2021.4.0.eb imkl-2022.0.1.eb imkl-2022.1.0.eb imkl-2022.2.0.eb imkl-2022.2.1.eb imkl-2023.0.0.eb imkl-2023.1.0.eb --module-only --installpath /tmp/$USER/pr3021" EB_CONTAINER= EB_REPO=easybuild-easyblocks /opt/software/slurm/bin/sbatch --job-name test_PR_3021 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11958

Test results coming soon (I hope)...

- notification for comment with ID 1768479365 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link

Test report by @boegelbot

Overview of tested easyconfigs (in order)

Build succeeded for 0 out of 7 (7 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/62f047ade15ad074aa28bc45ab6ada46 for a full test report.

@SebastianAchilles
Copy link
Member Author

Oh, --module-only does not work in combination with using a different --installpath.

@SebastianAchilles
Copy link
Member Author

@boegelbot please test @ generoso
EB_ARGS="imkl-2021.4.0.eb imkl-2022.0.1.eb imkl-2022.1.0.eb imkl-2022.2.0.eb imkl-2022.2.1.eb imkl-2023.0.0.eb imkl-2023.1.0.eb --installpath /tmp/$USER/pr3021"

@boegelbot
Copy link

@SebastianAchilles: Request for testing this PR well received on login1

PR test command 'EB_PR=3021 EB_ARGS="imkl-2021.4.0.eb imkl-2022.0.1.eb imkl-2022.1.0.eb imkl-2022.2.0.eb imkl-2022.2.1.eb imkl-2023.0.0.eb imkl-2023.1.0.eb --installpath /tmp/$USER/pr3021" EB_CONTAINER= EB_REPO=easybuild-easyblocks /opt/software/slurm/bin/sbatch --job-name test_PR_3021 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11959

Test results coming soon (I hope)...

- notification for comment with ID 1768523749 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS imkl-2021.4.0.eb
  • SUCCESS imkl-2022.0.1.eb
  • SUCCESS imkl-2022.1.0.eb
  • SUCCESS imkl-2022.2.0.eb
  • SUCCESS imkl-2022.2.1.eb
  • SUCCESS imkl-2023.0.0.eb
  • SUCCESS imkl-2023.1.0.eb

Build succeeded for 7 out of 7 (7 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/36a489c1e43bb300347d63360b010c8e for a full test report.

@SebastianAchilles
Copy link
Member Author

@boegelbot please test @ jsc-zen2
EB_ARGS="imkl-2021.2.0-gompi-2021a.eb imkl-2021.3.0-gompi-2021a.eb imkl-2021.4.0.eb imkl-2022.0.1.eb imkl-2022.1.0.eb imkl-2022.2.0.eb imkl-2022.2.1.eb imkl-2023.0.0.eb imkl-2023.1.0.eb --installpath /tmp/$USER/pr3021"

@boegelbot
Copy link

@SebastianAchilles: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=3021 EB_ARGS="imkl-2021.2.0-gompi-2021a.eb imkl-2021.3.0-gompi-2021a.eb imkl-2021.4.0.eb imkl-2022.0.1.eb imkl-2022.1.0.eb imkl-2022.2.0.eb imkl-2022.2.1.eb imkl-2023.0.0.eb imkl-2023.1.0.eb --installpath /tmp/$USER/pr3021" EB_REPO=easybuild-easyblocks /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_3021 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3577

Test results coming soon (I hope)...

- notification for comment with ID 1768927115 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS imkl-2021.2.0-gompi-2021a.eb
  • SUCCESS imkl-2021.3.0-gompi-2021a.eb
  • SUCCESS imkl-2021.4.0.eb
  • SUCCESS imkl-2022.0.1.eb
  • SUCCESS imkl-2022.1.0.eb
  • SUCCESS imkl-2022.2.0.eb
  • SUCCESS imkl-2022.2.1.eb
  • SUCCESS imkl-2023.0.0.eb
  • SUCCESS imkl-2023.1.0.eb

Build succeeded for 9 out of 9 (9 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/ec704274b02cc3b4a870006fed8d9c46 for a full test report.

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket merged commit 4705b65 into easybuilders:develop Oct 18, 2023
@boegel boegel changed the title fix CMAKE_PREFIX_PATH in mkl easyblock fix CMAKE_PREFIX_PATH in imkl easyblock Oct 25, 2023
@boegel boegel changed the title fix CMAKE_PREFIX_PATH in imkl easyblock fix CMAKE_PREFIX_PATH in imkl easyblock Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants