-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
take into account that posix_local
Python naming scheme only matters when using pip install
in PythonPackage easyblock
#2988
take into account that posix_local
Python naming scheme only matters when using pip install
in PythonPackage easyblock
#2988
Conversation
…s when using 'pip install' in PythonPackage easyblock (fixes easybuilders#2976)
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) edit: this was with a vanilla Ubuntu 22.04 setup that includes Python 3.10 + matching |
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) edit: this was with a vanilla Ubuntu 22.04 setup that includes Python 3.10 but without pip, no patching of |
Test report by @SebastianAchilles Overview of tested easyconfigs (in order)
Build succeeded for 7 out of 7 (7 easyconfigs in total) |
Test report by @SebastianAchilles Overview of tested easyconfigs (in order)
Build succeeded for 7 out of 7 (7 easyconfigs in total) |
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @akesandgren Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) This one is also Ubuntu 22.04 Python 3.10 without patching and without pip, thus using "setup.py install --prefix", i.e. the setup that triggered the problem solved by this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Going in, thanks @boegel! |
posix_local
Python naming scheme only matters when using pip install
in PythonPackage easyblock
(created using
eb --new-pr
)fixes #2976