Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use -x option for "go install" in GoPackage generic easyblock, to print commands as they are executed #2878

Merged
merged 5 commits into from
Feb 16, 2023

Conversation

smoors
Copy link
Contributor

@smoors smoors commented Feb 7, 2023

(created using eb --new-pr)

Go downloads and installs package dependencies listed in the go.mod file.
it would be good to have a log of all the packages that are installed, at least in debug mode

@boegel
Copy link
Member

boegel commented Feb 15, 2023

@smoors Is there any significant downside to always using this option?

(I don't consider making the logs a little bit more verbose a significant downside)

@boegel boegel changed the title add debug flag to gopackage easyblock use -x option for "go install" in GoPackage generic easyblock Feb 15, 2023
@smoors
Copy link
Contributor Author

smoors commented Feb 15, 2023

@smoors Is there any significant downside to always using this option?

(I don't consider making the logs a little bit more verbose a significant downside)

don't think so. i'll remove the debug clause.

@boegel
Copy link
Member

boegel commented Feb 16, 2023

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS elprep-5.1.1.eb
  • SUCCESS SeqKit-2.3.1.eb
  • SUCCESS Miller-6.4.0.eb
  • SUCCESS gofasta-0.0.5.eb
  • SUCCESS goalign-0.3.2.eb
  • SUCCESS gh-2.20.2.eb
  • SUCCESS rclone-1.57.0.eb

Build succeeded for 7 out of 7 (7 easyconfigs in total)
node3113.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/19a96d94f8b6041b495bf9f231db3b57 for a full test report.

@boegel boegel modified the milestones: 4.x, next release (4.7.1?) Feb 16, 2023
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 0ad8fe5 into easybuilders:develop Feb 16, 2023
@boegel boegel changed the title use -x option for "go install" in GoPackage generic easyblock use -x option for "go install" in GoPackage generic easyblock, to print commands as they are executed Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants