Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix version check for NVPTX library in sanity check of Clang easyblock #2783

Merged
merged 1 commit into from
Sep 10, 2022
Merged

fix version check for NVPTX library in sanity check of Clang easyblock #2783

merged 1 commit into from
Sep 10, 2022

Conversation

boegel
Copy link
Member

@boegel boegel commented Sep 10, 2022

fixes #2782

@boegel boegel added the bug fix label Sep 10, 2022
@boegel boegel added this to the next release (4.6.1) milestone Sep 10, 2022
@boegel boegel mentioned this pull request Sep 10, 2022
Merged
@SebastianAchilles
Copy link
Member

Test reports are available in easybuilders/easybuild-easyconfigs#16225 (comment)

SebastianAchilles
SebastianAchilles approved these changes Sep 10, 2022
View reviewed changes
Copy link
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Member

Going in, thanks @boegel!

@SebastianAchilles SebastianAchilles merged commit e4cf47b into easybuilders:develop Sep 10, 2022
@boegel boegel deleted the fix_version_check_clang_nvptx branch September 10, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianAchilles SebastianAchilles SebastianAchilles approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.6.1
Development

Successfully merging this pull request may close these issues.

fix sanity checks for Clang 11 when built with NVPTX support
2 participants
@boegel @SebastianAchilles