copy the list to avoid changing the original lists in DEFAULT_TARGETS_MAP for Clang and LLVM #2556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
requested changes
Aug 22, 2021
easybuild/easyblocks/c/clang.py
Outdated
| AARCH64: ['AArch64'], | ||
| POWER: ['PowerPC'], | ||
| X86_64: ['X86'], | ||
| AARCH32: 'ARM', |
There was a problem hiding this comment.
We import DEFAULT_TARGETS_MAP in the LLVM easyblock, so changing the values here means trouble there...
You changed the LLVM easyblock accordingly, but there could be other easyblocks out there (outside of the central repo) that import this constant.
boegel
approved these changes
Aug 22, 2021
There was a problem hiding this comment.
lgtm, test report coming up in easybuilders/easybuild-easyconfigs#13746
branfosj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)fixes #2555