Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sanity check in ESMF easyblock to take into account new binary names from version 8.1.0 onwards #2512

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Conversation

kilicomu
Copy link
Contributor

ESMF command line utility names changed with v8.1 - this PR updates the sanity check to reflect the changes:

  • ESMF_Info => ESMF_PrintInfo
  • ESMF_InfoC => ESMF_PrintInfoC

Also, there were some command line utilities missing from the previously implemented sanity check, so this adds those:

  • ESMF_Regrid
  • ESMF_Scrip2Unstruct

Closes #2481

@migueldiascosta
Copy link
Member

Test report by @migueldiascosta

Overview of tested easyconfigs (in order)

  • SUCCESS ESMF-8.0.1-foss-2020a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
sms - Linux centos linux 7.6.1810, x86_64, AMD EPYC 7601 32-Core Processor (zen), Python 2.7.5
See https://gist.github.com/090b49a4167e5203a47571e6d0e683ea for a full test report.

@migueldiascosta
Copy link
Member

lgtm - @kilicomu can you submit a test report with version 8.1? i.e. running eb on local easyconfig(s) with --include-easyblocks-from-pr=2512 -u should upload the test reports to a gist and post a comment here

(you may need to set up github integration, see https://docs.easybuild.io/en/latest/Integration_with_GitHub.html)

@kilicomu
Copy link
Contributor Author

Test report by @kilicomu

Overview of tested easyconfigs (in order)

  • SUCCESS ESMF-8.1.1-intel-2021a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
login2.pri.viking.alces.network - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6138 CPU @ 2.00GHz, Python 2.7.15
See https://gist.github.com/4f2d7eb759c987307dbac99aad6461eb for a full test report.

@kilicomu
Copy link
Contributor Author

@migueldiascosta Done - sorry about the first one; forgot to force the rebuild in my dev environment.

@migueldiascosta migueldiascosta changed the title Updates ESMF sanity check to 8.1 bin names update sanity check in ESMF easyblock to take into account new binary names from version 8.1.0 onwards Jul 14, 2021
Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Member

Going in, thanks @kilicomu!

@migueldiascosta migueldiascosta merged commit 09c8b6c into easybuilders:develop Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESMF sanity check
2 participants