Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance Python easyblock to explicitly disable installing core-pip when install_pip is not True #2476

Merged
merged 1 commit into from
Jun 21, 2021
Merged

enhance Python easyblock to explicitly disable installing core-pip when install_pip is not True #2476

merged 1 commit into from
Jun 21, 2021

Conversation

Flamefire
Copy link
Contributor

(created using eb --new-pr)

bartoldeman
bartoldeman approved these changes Jun 19, 2021
View reviewed changes
Copy link
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bartoldeman
Copy link
Contributor

we'll just need to compile some Python easyconfigs with this easyblock for verification

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire

Overview of tested easyconfigs (in order)

  • SUCCESS Python-2.7.15-GCCcore-8.2.0.eb
  • SUCCESS Python-2.7.18-GCCcore-10.2.0.eb
  • SUCCESS Python-3.7.2-GCCcore-8.2.0.eb
  • SUCCESS Python-3.9.5-GCCcore-10.3.0.eb
  • SUCCESS Python-3.8.2-GCCcore-9.3.0.eb

Build succeeded for 5 out of 5 (5 easyconfigs in total)
taurusi6309.taurus.hrsk.tu-dresden.de - Linux RHEL 7.9, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/75cd25e42b43a2dc82310e0a1141afc9 for a full test report.

@bartoldeman bartoldeman merged commit 733cce9 into easybuilders:develop Jun 21, 2021
@Flamefire Flamefire deleted the 20210616154251_new_pr_vUWnpaJBKx branch June 21, 2021 11:10
@bartoldeman bartoldeman added this to the next release (4.4.1) milestone Jun 21, 2021
@boegel boegel changed the title Explicitely disable installing core-pip when install_pip is not True enhance Python easyblock to explicitly disable installing core-pip when install_pip is not True Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartoldeman bartoldeman bartoldeman approved these changes

Assignees
No one assigned
Labels
change enhancement
Projects
None yet
Milestone
4.4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Flamefire @bartoldeman @boegel