Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only use siterc fix for NVHPC < 21.3 #2453

Merged
merged 2 commits into from
Jun 3, 2021

Conversation

damianam
Copy link
Member

@damianam damianam commented Jun 2, 2021

This fixes #2409

CC: @AndiH

@boegel boegel added the bug fix label Jun 2, 2021
@boegel boegel added this to the next release (4.4.1) milestone Jun 2, 2021
@boegel boegel changed the title To enable installations of NVHPC >= 21.3 where the siterc fix is no longer necessary only use siterc fix for NVHPC < 21.3 Jun 2, 2021
boegel added a commit to robert-mijakovic/easybuild-easyconfigs that referenced this pull request Jun 2, 2021
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Jun 2, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS NVHPC-20.9.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3111.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/1c3ab462be0b932d0a613135c2601054 for a full test report.

@boegel
Copy link
Member

boegel commented Jun 3, 2021

Also tested with NVHPC 21.3, see easybuilders/easybuild-easyconfigs#12572

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NVHPC: Remove SITERC_LIBRARY_PATH for Current Versions
2 participants