update CP2K easyblock w.r.t. running regtest for CP2K v8.1 #2350
Conversation
boegel
changed the title
|
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (4 easyconfigs in total) |
easybuild/easyblocks/c/cp2k.py
Outdated
| regtest_cmd = "%s -nosvn -nobuild -config %s" % (regtest_script, cfg_fn) | ||
| regtest_cmd = [regtest_script, '-nobuild', '-config', cfg_fn] | ||
| if LooseVersion(self.version) < LooseVersion('8.0'): | ||
| # -nosvn option was removed in CP2K 8.1 |
There was a problem hiding this comment.
it was already removed in 7.1, but just shows a warning there, so should be fine
There was a problem hiding this comment.
It was deprecated in 7.1, yeah, but that doesn't cause any actual trouble...
Should I change the version check to < 7.0?
There was a problem hiding this comment.
you could, or you could change the comment to say '-nosvn is not allowed in CP2K 8.1' or something like that.
both are fine to me
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
|
Going in, thanks @boegel! |
(created using
eb --new-pr)