Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass $CXXFLAGS to PDT's configure script via '-useropt' #2324

Merged
merged 1 commit into from
Feb 19, 2021
Merged

pass $CXXFLAGS to PDT's configure script via '-useropt' #2324

merged 1 commit into from
Feb 19, 2021

Conversation

geimer
Copy link
Contributor

@geimer geimer commented Jan 29, 2021

No description provided.

@boegel boegel added the bug fix label Feb 3, 2021
@boegel boegel added this to the 4.3.3 (next release) milestone Feb 3, 2021
@boegel boegel changed the title PDT: Pass EB compiler flags to configure via -useropt PDT: Pass EB compiler flags to configure via '-useropt' Feb 3, 2021
@boegel boegel changed the title PDT: Pass EB compiler flags to configure via '-useropt' pass $CXXFLAGS to PDT's configure script via '-useropt' Feb 3, 2021
@boegel
Copy link
Member

boegel commented Feb 19, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS PDT-3.25-GCCcore-8.2.0.eb
  • SUCCESS PDT-3.25-GCCcore-8.3.0.eb
  • SUCCESS PDT-3.25.1-GCCcore-9.3.0.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3503.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/0c14591a60c1a4cd9d7c57c70c684672 for a full test report.

boegel
boegel approved these changes Feb 19, 2021
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Feb 19, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS PDT-3.22-foss-2016a.eb
  • SUCCESS PDT-3.25-GCCcore-8.2.0.eb
  • SUCCESS PDT-3.25-GCCcore-8.3.0.eb
  • SUCCESS PDT-3.25.1-GCCcore-9.3.0.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
node2666.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/defd4211cebd572a29788ab62ab339a7 for a full test report.

@boegel boegel merged commit d2b5618 into easybuilders:develop Feb 19, 2021
@geimer geimer deleted the pdt_handle_compiler_flags branch February 19, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@geimer @boegel