-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update OpenFOAM easyblock for changes in v2012 #2321
Conversation
I would argue that the it should probably always have been 'eb-mpi' or something like that the entire time. It is just a matter of how EasyBuild decided to patch the etc/config.sh/mpi file. Could have easily defined it there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Hm, how did you upload test report to easyblock prs? Anyway.. it worked fine for my as well so i think it's good to go. |
@Micket Just combine |
This patch resolves sanity check error with new OpenFOAM v2012 layout proposed in pr #11876.
Mpi related libraries are located in platform/..../eb-mpi rather than in platform/..../mpi.
Edit: requires EasyBlock changes in #2321