Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correctly determine path to active binutils in TensorFlow easyblock #2218

Merged
merged 5 commits into from
Sep 4, 2023
Merged

correctly determine path to active binutils in TensorFlow easyblock #2218

merged 5 commits into from
Sep 4, 2023

Conversation

boegel
Copy link
Member

@boegel boegel commented Oct 31, 2020 •
edited
Loading

Fix for failing installation when EasyBuild was configured with binutils in --filter-deps, and taking into account the use of --rpath

@boegel boegel added enhancement EESSI Related to EESSI project labels Oct 31, 2020
@boegel boegel added this to the 4.3.2 milestone Oct 31, 2020
@boegel
Copy link
Member Author

boegel commented Oct 31, 2020

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS TensorFlow-2.3.1-foss-2020a-Python-3.8.2.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3412.kirlia.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz (cascadelake), Python 2.7.5
See https://gist.github.com/e63490e52666055fc35fa7e6caa6da1d for a full test report.

@boegel boegel changed the title support using system binutils in TensorFlow easyblock, taking into account alterate sysroot support using system binutils in TensorFlow easyblock, taking into account alterate sysroot (WIP) Oct 31, 2020
@boegel
Copy link
Member Author

boegel commented Oct 31, 2020

Marking this as WIP, since this change it not enough to get the TensorFlow installation working in an environment with a custom sysroot + use of RPATH... The latter is probably not correctly taken into account yet in the TensorFlow easyblock, and may to resolve the problem being fixed here a bit differently.

@boegel
determine path to binutils location via which('ld'), so ld wrapper sc…
f939eea 
…ript is picked up when EasyBuild was configured with --rpath
@boegel boegel mentioned this pull request Nov 2, 2020
Merged
@boegel boegel changed the title support using system binutils in TensorFlow easyblock, taking into account alterate sysroot (WIP) support using system binutils in TensorFlow easyblock, taking into account alterate sysroot Nov 2, 2020
Flamefire
Flamefire suggested changes Nov 2, 2020
View reviewed changes
easybuild/easyblocks/t/tensorflow.py Outdated Show resolved Hide resolved
easybuild/easyblocks/t/tensorflow.py Outdated Show resolved Hide resolved
@boegel boegel changed the title support using system binutils in TensorFlow easyblock, taking into account alterate sysroot correctly determine path to active binutils in TensorFlow easyblock Nov 2, 2020
@boegel
Copy link
Member Author

boegel commented Nov 2, 2020

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS TensorFlow-2.3.1-foss-2020a-Python-3.8.2.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3575.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/0e79e34dd8c46eb0c7e4f7393ec04e30 for a full test report.

@boegel
Copy link
Member Author

boegel commented Nov 2, 2020

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS TensorFlow-2.3.1-foss-2020a-Python-3.8.2.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3105.skitty.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/11e6a91cae5c13fc7600ef7d665ddf5b for a full test report.

@boegel boegel modified the milestones: 4.3.2 (next release), 4.4.0 Dec 1, 2020
@Flamefire Flamefire mentioned this pull request Mar 10, 2021
Closed
@akesandgren
Copy link
Contributor

@boegel conflict resolution needed.

@boegel boegel mentioned this pull request Apr 11, 2021
Closed
@boegel boegel modified the milestones: 4.4.0, release after 4.4.0 May 26, 2021
@boegel boegel added this to the release after 4.5.2 milestone Jan 14, 2022
@boegel boegel modified the milestones: 4.5.3, release after 4.5.3 Feb 9, 2022
@boegel boegel modified the milestones: 4.5.5, release after 4.5.5 Jun 4, 2022
@terjekv
Copy link
Contributor

terjekv commented Feb 23, 2023

What is the long-term status of this PR? I'm looking at what --from-pr-fixes we can drop when building in [NE]ESSI. :)

@boegel
Copy link
Member Author

boegel commented Mar 1, 2023

@terjekv Yeah, we should really get this merged...

Need to check back on the discussion, and see if any changes should be made before doing a broad round of testing (both in and outside of EESSI build environment)

@boegel boegel modified the milestones: 4.7.3, release after 4.7.3 Jul 5, 2023
@boegel boegel mentioned this pull request Aug 30, 2023
Closed
ocaisa
ocaisa approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in use for a long time in EESSI so ok from me.

@ocaisa ocaisa merged commit ff6fe69 into easybuilders:develop Sep 4, 2023
@boegel boegel deleted the tensorflow_binutils_fix branch September 4, 2023 15:56
@boegel boegel mentioned this pull request Dec 20, 2023
Merged
@Flamefire Flamefire mentioned this pull request Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flamefire Flamefire Flamefire requested changes

@ocaisa ocaisa ocaisa approved these changes

Assignees
No one assigned
Labels
bug fix EESSI Related to EESSI project
Projects
None yet
Milestone
4.8.1
Development

Successfully merging this pull request may close these issues.
5 participants
@boegel @akesandgren @terjekv @Flamefire @ocaisa