-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XALT EasyBlock #1942
Add XALT EasyBlock #1942
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should support more options from XALT
Thanks for the feedback @victorusu. The approach I took was to keep the EasyBlock as lean as possible and keep the specifics in the XALT EasyConfig. Additional XALT EasyConfigs could be created for other permutations, such as the curl transmission method. (If not for the XALT prefix behavior, I likely would have used the standard ConfigureMake EasyBlock.) Alternatively, the EasyBlock could be a much more customized version of the ConfigureMake EasyBlock that hard codes more XALT options, as you are suggesting. From what I can tell, the first approach seems to be more closely aligned with the EasyBuild "spirit". @boegel, do you have a preference? |
@boegel would still appreciate your feedback on this. Thanks! |
@samcmill I'm happy to clarify anything if needed, either via this PR or more directly (EasyBuild Slack channel, or a short conf call), please don't hesitate to reach out! |
@boegel @victorusu The latest commit should address most of your feedback. Thanks! The step monkeying with the install path is still there. I'll revisit that once xalt/xalt#26 is merged. I'm unsure about the alternative linker stuff, so no changes for that yet. @victorusu - can you please clarify? |
The latest changes incorporate the This is ready for another review. |
@boegel @victorusu can you please review this again? |
@boegel @victorusu can you please review this again? |
@samcmill I'm sorry for not getting back to this yet, it's on my TODO list for EasyBuild v4.2.1 (see https://github.com/orgs/easybuilders/projects/5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samcmill Sorry for the long delay in getting back to you on this... Do let me know if something isn't clear!
Tested with easybuilders/easybuild-easyconfigs#9792, good to go, thanks a lot for your efforts on this @samcmill! |
Specialized variant of the ConfigureMake EasyBlock for building and installing XALT.
cc @rtmclay