Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sidestep using the config.guess that comes with a package in ConfigureMake generic easyblock #1506
sidestep using the config.guess that comes with a package in ConfigureMake generic easyblock #1506
Changes from 2 commits
17d6c76
cd69782
fd6bdb7
c47853a
ef81748
6dcb5c1
e120a44
5278326
5f8fda2
d7115ea
80a7a7b
a15fc10
2961ea7
c49cd68
4994369
2309b88
453dd1e
8ef7799
28ff190
ebb4e97
e2c1f70
e637804
a434e86
2c68803
9f9d214
754691f
aa4d649
adfc4fc
7b85a0c
6278426
20a60c1
5cfff14
f9cb4de
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
undefined name 'EasyBuildError'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ocaisa No need for this,
run_cmd
check the exit code of the command that was run already by default, and will produce a clear error message when!= 0
.So, you can use:
(
_
is often used to signal you're ignoring part of the return value)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ocaisa I like the
cmd = ' '.join([...])
option better, there's little point in using a dict here to format the command...