Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silently missing new bottle when original bottle block has less than two expressions #14

Open
easoncxz opened this issue May 17, 2020 · 0 comments
Labels

Comments

@easoncxz
Copy link
Owner

Turns out the Parser::AST::Node tree structure is different for

bottle do
  root_url "whatever"
end

vs

bottle do
  foobar
  root_url "whatever"
end

One is like

(block
  (send nil :bottle)
  (args)
  (send nil :root_url
    (str "https://dl.bintray.com/easoncxz/homebrew-bottles")))

While the other is like

 (block
  (send nil :bottle)
  (args)
  (begin
    (send nil :cellar
      (sym :any_skip_relocation))
    (send nil :rebuild
      (int 1))
    (send nil :root_url
      (str "https://dl.bintray.com/easoncxz/homebrew-bottles"))
    (send nil :sha256
      (hash
        (pair
          (str "4be7efbbfb251b46a860080b753bd280b36726e1d8b7815893e35354ae33f730")
          (sym :yosemite))))))

Notice that an extra layer of (:begin ...) appears if there are more than one expression.

@easoncxz easoncxz added the bug label May 17, 2020
easoncxz added a commit that referenced this issue May 17, 2020
easoncxz added a commit to easoncxz/homebrew-tap that referenced this issue May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant