Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update easol-canvas to v4.x #9

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Update easol-canvas to v4.x #9

merged 1 commit into from
Mar 22, 2023

Conversation

sldblog
Copy link
Contributor

@sldblog sldblog commented Mar 22, 2023

The latest version of the canvas gem is v4.0.0, which enforces custom type keys to be defined in lowercase.

This is a breaking-style change, requiring the major version change.

@sldblog
Update easol-canvas to v4.x
db7e6db 
The latest version of canvas is v4.0.0, which enforces custom type keys
to be defined in lowercase.

This is a breaking-style change, requiring the major version change.
@sldblog
Copy link
Contributor Author

sldblog commented Mar 22, 2023

NoMethodError in company/sites/image_variables#destroy

@eballantine eballantine self-assigned this Mar 22, 2023
eballantine
eballantine approved these changes Mar 22, 2023
View reviewed changes
Copy link

@eballantine eballantine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

& Q just to confirm, we're not expecting this to require any action from theme devs?

@eballantine eballantine removed their assignment Mar 22, 2023
@sldblog
Copy link
Contributor Author

sldblog commented Mar 22, 2023 •
edited
Loading

Q just to confirm, we're not expecting this to require any action from theme devs?

As far as I can see, once released merged and tagged, dependabot will create PR on each theme repo to switch to the newer version of this action. I think that should be enough to roll it out. I'm not aware of anything else

@sldblog
Copy link
Contributor Author

sldblog commented Mar 22, 2023

Ah, I will have to update https://github.com/easolhq/easol-theme-template too

@sldblog sldblog merged commit a3010cf into main Mar 22, 2023
@sldblog sldblog deleted the update-canvas-for-custom-type-case branch March 22, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eballantine eballantine eballantine approved these changes

@ianmooney ianmooney Awaiting requested review from ianmooney

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sldblog @eballantine