Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates in IntegerUtility #284

Merged
merged 5 commits into from
Feb 1, 2024
Merged

Conversation

vickysharma0812
Copy link
Member

@vickysharma0812 vickysharma0812 commented Feb 1, 2024

  • Modifying RemoveDuplicates
  • Now temp array is not allocatable
  • The code may break if unallocatable array is send

Generated summary (powered by Graphite)

TL;DR

This pull request modifies the AppendUtility.F90 and IntegerUtility@Methods.F90 files. It introduces changes to the Expand interface and adds a new implementation for removing duplicates in the RemoveDuplicates_1.inc file.

What changed

  • In the AppendUtility.F90 file, the Expand interface is modified to include new subroutines for expanding integer and real vectors.
  • In the IntegerUtility@Methods.F90 file, the RemoveDuplicates_1a, RemoveDuplicates_1b, RemoveDuplicates_1c, and RemoveDuplicates_1d procedures are modified to use the new implementation in the RemoveDuplicates_1.inc file.

How to test

To test the changes, follow these steps:

  1. Compile and build the project.
  2. Run the relevant test cases that use the Expand interface and the RemoveDuplicates procedures.
  3. Verify that the expanded vectors and removed duplicates are correct.

Why make this change

  • The changes to the AppendUtility.F90 file introduce new subroutines for expanding integer and real vectors, which can be useful in various scenarios.
  • The modifications to the IntegerUtility@Methods.F90 file update the RemoveDuplicates procedures to use a new implementation in the RemoveDuplicates_1.inc file, potentially improving the efficiency and accuracy of removing duplicates in integer vectors.

Copy link
Member Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

- Modifying RemoveDuplicates
@vickysharma0812 vickysharma0812 force-pushed the 02-01-Updates_in_IntegerUtility branch from de11735 to 5d62fd4 Compare February 1, 2024 12:35
@vickysharma0812 vickysharma0812 self-assigned this Feb 1, 2024
@vickysharma0812 vickysharma0812 merged commit c801d77 into dev Feb 1, 2024
1 check passed
@vickysharma0812 vickysharma0812 deleted the 02-01-Updates_in_IntegerUtility branch March 21, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant