Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Corey/configurable-logging-timeout #89

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

dchw
Copy link

@dchw dchw commented Aug 2, 2022

This is what I am working on upstreaming. Perhaps test this here while I work on that, as Vlad suggested?

Sample TOML config:

[health]
  frequency = "10s"
  timeout = "1m"
  allowedFailures = 3

Its totally an optional section, and each has a default value that matches what it used to do.

@dchw dchw requested review from alexcb and vladaionescu August 2, 2022 23:04
@dchw
Copy link
Author

dchw commented Aug 2, 2022

Since the timeout failing appears to be what kills a session when someone Ctrl+C kills earthly, our best bet is likely a high-frequency, high-timeout configuration. We can tune allowed failures once we get to a point on the other two that is good.

Copy link

@alexcb alexcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool to see these settings available via the buildkit toml now.

@dchw
Copy link
Author

dchw commented Aug 2, 2022

Upstreaming here: moby#2998

@dchw dchw merged commit 0b5cf19 into earthly-main Aug 3, 2022
@dchw dchw deleted the corey/configurable-logging-timeout branch August 3, 2022 00:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants