Support FireLens configuration #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaorimatz
commented
Dec 5, 2019
lib/hako/schedulers/ecs.rb
Outdated
| user = container.user | ||
| # Set user to '0' if not specified, otherwise a new task definition is | ||
| # always registered because user is set to '0' on a firelens container. | ||
| # If a user other than root is specified on a firelens container, |
There was a problem hiding this comment.
The exception I've got when specifying a non-root user is:
Aws::ECS::Errors::ClientException: If 'user' field is specified on firelens container, then 'UID' has to be '0'.
|
How is this PR? I would like to merge this PR. |
kaorimatz
force-pushed
the
support-firelens-configuration
branch
from
1f1fd36
to
8e86753
Compare
|
@eagletmt Would you mind taking a look at the change, because it's been a while since I last worked on this project? 🙇♂️ The failure in CI / RuboCop is not related to this change. I can push a fix to the master branch if that's okay with you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new parameter called firelens_configuration, which maps to ContainerDefinition's firelensConfiguration, to the container definition.
References: