fix for _get_schema_v2 always returning None

[sebcampos]

fix for _get_schema_v2 always returning None

[eadwinCode]

@sebcampos Thanks for working on this. Can you please fix the tests?

[sebcampos]

Sure thing looks like it affected the enum tests.I’ll look a little more deeply and update the PR once I understand why it’s causing this

On Sun, 27 Oct 2024 at 13:52, Tochukwu wrote:

@sebcampos [https://github.com/sebcampos] Thanks for working on this. Can you please fix the tests? — Reply to this email directly, view it on GitHub [#14 (comment)], or unsubscribe [https://github.com/notifications/unsubscribe-auth/APQVOBJMMOCG5EURWMRAHE3Z5VG7BAVCNFSM6AAAAABQVFF2WKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBQGE3TCMBUGQ] . You are receiving this because you were mentioned.[https://github.com/notifications/beacon/APQVOBJUCJ3L3LCBTKX367DZ5VG7BA5CNFSM6AAAAABQVFF2WKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUROIHCI.gif] Message ID: ***@***.***> Sent with Criptext secure email[https://api.criptext.com/email/open/%3C1730108274743.066511%40criptext.com%3E]

[sebcampos]

It looks like the tests are failing because there was a change to how pydantic handles the “allOf” enum value. * Pydantic v2.9 introduced a change that simplifies the use ofallOf. In many cases, you can now achieve the same validation using nested models and inheritance without explicitly usingallOf. pydantic/pydantic#478 [pydantic/pydantic#478] If I switch pydantic version to2.8.2 the tests pass.I’ll update the test cases to take into account versions 2.9.2 and above in my PR

On Mon, 28 Oct 2024 at 02:37, sebastian campos wrote: Sure thing looks like it affected the enum tests.I’ll look a little more deeply

and update the PR once I understand why it’s causing this

On Sun, 27 Oct 2024 at 13:52, Tochukwu wrote:

@sebcampos [https://github.com/sebcampos] Thanks for working on this. Can you please fix the tests? — Reply to this email directly, view it on GitHub [#14 (comment)], or unsubscribe [https://github.com/notifications/unsubscribe-auth/APQVOBJMMOCG5EURWMRAHE3Z5VG7BAVCNFSM6AAAAABQVFF2WKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBQGE3TCMBUGQ] . You are receiving this because you were mentioned.[https://github.com/notifications/beacon/APQVOBJUCJ3L3LCBTKX367DZ5VG7BA5CNFSM6AAAAABQVFF2WKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUROIHCI.gif] Message ID: ***@***.***> Sent with Criptext secure email[https://api.criptext.com/email/open/%3C1730606068561.537277%40criptext.com%3E]

[eadwinCode]

@sebcampos Thanks for your hard work here. I will merge this and fix it from my end.

[sebcampos]

Thanks for your great work and Django addition!

On Mon, 18 Nov 2024 at 13:25, Tochukwu wrote:

Merged #14 [#14] into master. — Reply to this email directly, view it on GitHub [#14 (comment)], or unsubscribe [https://github.com/notifications/unsubscribe-auth/APQVOBLKHUMVNFQQY4HLOP32BJLKXAVCNFSM6AAAAABQVFF2WKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGM2DANBZG4ZTGMA] . You are receiving this because you were mentioned.[https://github.com/notifications/beacon/APQVOBOKV6DGUBAFTJOZ7HT2BJLKXA5CNFSM6AAAAABQVFF2WKWGG33NNVSW45C7OR4XAZNWJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XKUY3PNVWWK3TUL5UWJTYAAAAAHES5NGZA.gif] Message ID: ***@***.***> Sent with Criptext secure email[https://api.criptext.com/email/open/%3C1731988290705.650168%40criptext.com%3E]