[bugfix] made date calculation efficient #5593
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robin6939
force-pushed
the
hotfix/efficient-date-calculation
branch
from
f16ef00 to
8ad25ca
Compare
duncdrum
requested changes
Jan 1, 2025
There was a problem hiding this comment.
@Robin6939 thank you for the PR. It's a good start but requires more work. There are a number of salient test failures in the current state.
- https://github.com/eXist-db/exist/actions/runs/12560378555/job/35017594952?pr=5593#step:6:3232 shows a new date being returned, and also in a different format
YYYY-MM-DD+HH:MMas opposed toYYYY-MM-DD - a number of
NULLsand NPE ouch https://github.com/eXist-db/exist/actions/runs/12560378555/job/35017594952?pr=5593#step:6:3106
I would suggest addressing the NPEs first, and then take a look at the xml specs regarding the expected and acceptable formats for the remaining test. If you have questions about the existing tests feel free to ask.
|
Hi @duncdrum |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Replaced XMLGregorianCalendar with the java.time API, which is designed for modern, efficient date-time manipulation. Any query is now executed within a couple of seconds.
Reference:
#5045
Type of tests:
Didn't add any test cases since this was for efficiency improvement. Have done dev testing on my part.