Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a page about XSL:FO rendering #726

Merged
merged 3 commits into from
Jan 12, 2022
Merged

Conversation

adamretter
Copy link
Contributor

@adamretter adamretter commented Jan 7, 2022

No description provided.

@joewiz
Copy link
Member

joewiz commented Jan 7, 2022

@adamretter Pages are automatically discovered via their <keyword> element, but they need to be manually entered into the documentation TOC page: https://github.com/eXist-db/documentation/blob/master/src/main/xar-resources/data/documentation/documentation.xml.

Copy link
Member

@joewiz joewiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM - just a few minor issues, as noted inline.

@adamretter
Copy link
Contributor Author

@joewiz Thanks for the speedy review, I just pushed an additional commit to address your suggestions :-)

@joewiz
Copy link
Member

joewiz commented Jan 12, 2022

We have a CI error, which I don't think is related to this PR:

Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.12.0:gulp (gulp build) on project exist-documentation: Failed to run task: 'gulp.js ' failed. org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1) -> [Help 1]

... but the master branch is passing CI, so why would this PR suddenly throw an error?

@joewiz
Copy link
Member

joewiz commented Jan 12, 2022

I see there's a dependabot PR for a newer version of eirslett:frontend-maven-plugin, so I'll work through the dependabot backlog and merge that PR. Hopefully that'll fix this.

@joewiz
Copy link
Member

joewiz commented Jan 12, 2022

@dependabot rebase

@joewiz
Copy link
Member

joewiz commented Jan 12, 2022

@dependabot why no love?

ok, since master is green after applying the other dependabot PRs, I'll just merge and hope that master remains green.

@joewiz joewiz merged commit ed4bc34 into eXist-db:master Jan 12, 2022
This was referenced Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants