-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a page about XSL:FO rendering #726
Conversation
@adamretter Pages are automatically discovered via their |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM - just a few minor issues, as noted inline.
@joewiz Thanks for the speedy review, I just pushed an additional commit to address your suggestions :-) |
We have a CI error, which I don't think is related to this PR:
... but the master branch is passing CI, so why would this PR suddenly throw an error? |
I see there's a dependabot PR for a newer version of eirslett:frontend-maven-plugin, so I'll work through the dependabot backlog and merge that PR. Hopefully that'll fix this. |
@dependabot rebase |
@dependabot why no love? ok, since master is green after applying the other dependabot PRs, I'll just merge and hope that master remains green. |
No description provided.