[20596] Feature: topic keys with non breaking ABI (humble backport) #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refs #20156: Add is_key_ field to identify member as key Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20156: Add has_any_member_with_annotation() method for a struct Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20310: Define v2 ABI identifier Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20310: Update Message introspection with a new static key_members_array in the parent messagemembers Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20310: Review suggestions Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20310: NITs Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
MiguelCompany
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the work from #3 into
vulcanexus-humble.It gave no conflicts (hooray !)
Important
If we port to ROS 2
humbleat any time, this PR relies onFast DDS v2.6.8because it needs eProsima/Fast-DDS#4308 and eProsima/Fast-DDS#4353