Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20411] Improve junit_summary robustness #60

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Feb 14, 2024

Description

#56 introduced a new action to create summaries from jUnit reports. It also introduced support in the colcon_test action to create jUnit reports from CTest ones for CMake versions where CTest does not have native support for jUnit reporting. For the latter cases, the generated jUnit reports where not complete enough, and the junit_summary.py script was not robust enough to cope with the differences. This PR

  • Extends the generated reports to have some missing required properties
  • Improves the robustness to the junit_summary.py script so if can generate summaries from the different jUnit reports.

Depends on:

Contributor Checklist

  • Commit messages follow the company guidelines.
  • N/A: Changes are API compatible.
  • N/A: New features have been added to the versions.md and README.md files (if applicable).

Reviewer Checklist

  • The title and description correctly express the PR's purpose.
  • The Contributor checklist is correctly filled.

@EduPonz EduPonz force-pushed the hotfix/robustness_junit_summary branch from ba65271 to e6e1be5 Compare February 14, 2024 08:54
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz force-pushed the hotfix/robustness_junit_summary branch from e6e1be5 to 8a687be Compare February 14, 2024 09:45
multiplatform/colcon_test/action.yml Outdated Show resolved Hide resolved
resources/junit_summary.py Outdated Show resolved Hide resolved
ubuntu/colcon_test/action.yml Outdated Show resolved Hide resolved
windows/colcon_test/action.yml Outdated Show resolved Hide resolved
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz force-pushed the hotfix/robustness_junit_summary branch from 8387ccb to 5d75fac Compare February 14, 2024 10:39
resources/junit_summary.py Outdated Show resolved Hide resolved
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
Copy link
Author

EduPonz commented Feb 14, 2024

@EduPonz EduPonz merged commit 5bcd968 into main Feb 14, 2024
1 check passed
@EduPonz EduPonz deleted the hotfix/robustness_junit_summary branch February 14, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants