-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20411] Improve junit_summary robustness #60
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba65271
to
e6e1be5
Compare
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
e6e1be5
to
8a687be
Compare
MiguelCompany
requested changes
Feb 14, 2024
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
8387ccb
to
5d75fac
Compare
MiguelCompany
requested changes
Feb 14, 2024
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
MiguelCompany
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#56 introduced a new action to create summaries from jUnit reports. It also introduced support in the colcon_test action to create jUnit reports from CTest ones for CMake versions where CTest does not have native support for jUnit reporting. For the latter cases, the generated jUnit reports where not complete enough, and the junit_summary.py script was not robust enough to cope with the differences. This PR
Depends on:
Contributor Checklist
versions.md
andREADME.md
files (if applicable).Reviewer Checklist