Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19593] Update fastdds-build workflow to manually set dependencies version #35

Merged
merged 5 commits into from
Oct 24, 2023
Merged

[19593] Update fastdds-build workflow to manually set dependencies version #35

merged 5 commits into from
Oct 24, 2023

Conversation

rsanchez15
Copy link
Contributor

No description provided.

@rsanchez15 rsanchez15 force-pushed the feature/manual_fastdds_build branch 4 times, most recently from 2e7cddf to dc077f6 Compare September 20, 2023 12:16
JLBuenoLopez
JLBuenoLopez suggested changes Sep 20, 2023
View reviewed changes
.github/workflows/build_fastdds.yml Outdated Show resolved Hide resolved
.github/workflows/build_fastdds.yml Show resolved Hide resolved
.github/workflows/build_fastdds.yml Outdated Show resolved Hide resolved
.github/workflows/build_fastdds.yml Outdated Show resolved Hide resolved
multiplatform/fetch_fastdds_manual/action.yml Outdated Show resolved Hide resolved
ubuntu/fetch_fastdds_manual/action.yml Outdated Show resolved Hide resolved
windows/fetch_fastdds_manual/action.yml Outdated Show resolved Hide resolved
windows/fetch_fastdds_manual/action.yml Outdated Show resolved Hide resolved
windows/fetch_fastdds_manual/action.yml Outdated Show resolved Hide resolved
.github/workflows/build_fastdds.yml Outdated Show resolved Hide resolved
@rsanchez15 rsanchez15 changed the title Update fastdds-build workflow to manually set dependencies version [19593] Update fastdds-build workflow to manually set dependencies version Sep 20, 2023
@JLBuenoLopez
Copy link
Contributor

It should be nice to update the README including this new action in order to keep the repo documented.

@rsanchez15 rsanchez15 force-pushed the feature/manual_fastdds_build branch 2 times, most recently from c76d819 to 0d7acab Compare October 6, 2023 08:47
JLBuenoLopez
JLBuenoLopez reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor typo

README.md Outdated Show resolved Hide resolved
@rsanchez15
Update fastdds-build workflow to manually set dependencies version
37245ae 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15
Keep fetch dependencies from .repos option
bdf24ac 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15
Do not scape " in inputs comments
9091796 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15
Update README and actions description
5e2a929 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15
Update actions branch to main
ff9d38a 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
JLBuenoLopez
JLBuenoLopez approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsanchez15 rsanchez15 merged commit d7cdcfb into main Oct 24, 2023
1 check passed
@rsanchez15 rsanchez15 deleted the feature/manual_fastdds_build branch October 24, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsanchez15 @JLBuenoLopez