Fix fragment capacity overflow #296

Acuadros95 · 2021-12-01T10:49:49Z

Last fragment contains local_args->data_size + SUBHEADER_SIZE + WRITE_DATA_PAYLOAD_SIZE data, and previous if condition only checks for local_args->data_size <= buffer_capacity:

Micro-XRCE-DDS-Client/src/c/core/session/write_access.c

Lines 180 to 186 in e1ef8c6

    
           if (local_args->data_size <= buffer_capacity) 
        
           { 
        
               uxr_buffer_submessage_header(&temp_ub, SUBMESSAGE_ID_FRAGMENT, (uint16_t) local_args->data_size, 
        
                       FLAG_LAST_FRAGMENT); 
        
               uxr_set_reliable_buffer_size(&stream->base, stream->last_written, 
        
                       local_args->data_size + SUBHEADER_SIZE + WRITE_DATA_PAYLOAD_SIZE); 
        
           }

pablogs9 · 2021-12-01T10:53:37Z

Good catch

Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>

Fix fragment capacity overflow

87e36d3

Acuadros95 requested a review from pablogs9 December 1, 2021 10:49

pablogs9 approved these changes Dec 1, 2021

View reviewed changes

Acuadros95 merged commit abac482 into develop Dec 1, 2021

pablogs9 deleted the fix/fragment_overflow branch December 1, 2021 10:54

roncapat pushed a commit to roncapat/Micro-XRCE-DDS-Client that referenced this pull request Dec 3, 2021

Fix fragment capacity overflow (eProsima#296)

a245c69

Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix fragment capacity overflow #296

Fix fragment capacity overflow #296

Acuadros95 commented Dec 1, 2021 •

edited

Loading

pablogs9 commented Dec 1, 2021

	if (local_args->data_size <= buffer_capacity)
	{
	uxr_buffer_submessage_header(&temp_ub, SUBMESSAGE_ID_FRAGMENT, (uint16_t) local_args->data_size,
	FLAG_LAST_FRAGMENT);
	uxr_set_reliable_buffer_size(&stream->base, stream->last_written,
	local_args->data_size + SUBHEADER_SIZE + WRITE_DATA_PAYLOAD_SIZE);
	}

Fix fragment capacity overflow #296

Fix fragment capacity overflow #296

Conversation

Acuadros95 commented Dec 1, 2021 • edited Loading

pablogs9 commented Dec 1, 2021

Acuadros95 commented Dec 1, 2021 •

edited

Loading