[21672] Fix data race in TypeObjectFactory::get_instance
(backport #5238)
#5241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While debugging an error reported by LeakSanitizer in #4916, an important data race was discovered in
TypeObjectFactory::get_instance
.The test that PR adds is creating several writers from different threads simultaneously.
This leads to calling
TypeObjectFactory::get_instance
when registering the local writer (during the creation of itsWriterProxyData
).The data race made several factories to be constructed, but only one was assigned to the global g_instance pointer.
Only one of the factories was destroyed when the process finished, making LeakSanitizer complain.
This PR adds a mechanism based on an atomic enumeration holding the state of the singleton instance.
@Mergifyio backport 2.14.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A: Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A: New feature has been added to the
versions.md
file (if applicable).N/A: New feature has been documented/Current behavior is correctly described in the documentation.
[x]: Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #5238 done by [Mergify](https://mergify.com).