-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unsigned specification to literals #5125
Conversation
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
This fix should be present also in 3.x and 2.10.x. |
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
It wasn't straightforward to test this one on our CI, so I went ahead and just tested locally. I added an extra commit that I was missing: 89b7945 This is the job that we are aiming to get to green: https://build.ros2.org/view/Rci/job/Rci__nightly-performance_ubuntu_noble_amd64/68/ These are the warnings that we want to resolve by merging this PR: https://build.ros2.org/view/Rci/job/Rci__nightly-performance_ubuntu_noble_amd64/68/gcc/ And I'm attaching the output of my local environment for the performance_test repo in case that helps to check if the PR addresses the problem. ros2_rolling/log/latest_build/performance_test/stdout_stderr.log Let me know if I can do something else to help merging this, thank you! |
PTAL 🙏 |
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Hi @Blast545, thanks for your contribution. |
Description
As the title says. The performance jobs in the OSRF buildfarm are getting a warning because the indexes used with the
iHandle InstanceHandle_t
are being forwarded to a template, and the compiler thinks that there may be lost data converting 0 and 15 from int to unsigned int.Reference failing job: https://build.ros2.org/view/Rci/job/Rci__nightly-performance_ubuntu_noble_amd64/68/gcc/
Silly error, I think this PR should fix it.
I will test this PR in the buildfarm before asking for the PR to be merged.
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist