Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19036] Link SHM locator kind with Fast DDS major version #5116

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Jul 30, 2024

Description

This PR links the definition of the SHM locator kind to the Fast DDS major version. That way, we avoid keeping SHM locators from participants of different majors, as the port structure will be different (the SHM port ABI version will change from major to major).

This PR fixes compatibility issues with 2.x versions when all the participants have an SHM transport without requiring further modifications on any 2.x version.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
    • A static assert is added to ensure the value
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • ❌ Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz EduPonz added this to the v3.0.0 milestone Jul 30, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 30, 2024
@EduPonz EduPonz marked this pull request as ready for review July 30, 2024 09:05
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

Copy link
Contributor

@rsanchez15 rsanchez15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my side

@MiguelCompany MiguelCompany merged commit 0b671f2 into master Jul 30, 2024
16 of 17 checks passed
@MiguelCompany MiguelCompany deleted the feature/shm_locator_kind_linked_major branch July 30, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants