Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21363] Migration guide #5102

Merged
merged 10 commits into from
Jul 30, 2024
Merged

[21363] Migration guide #5102

merged 10 commits into from
Jul 30, 2024

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Jul 24, 2024

Description

This PR updates the Upgrading.md document, which aims to help during the migration process from eProsima Fast DDS version 2 to Fast DDS version 3.
It contains the changes that a user may need to apply to migrate to Fast DDS v3.0.0.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A; If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@elianalf elianalf added this to the v3.0.0 milestone Jul 24, 2024
@elianalf elianalf force-pushed the migration_guide branch 2 times, most recently from 3585ed0 to 526f0bc Compare July 24, 2024 14:43
elianalf and others added 6 commits July 26, 2024 10:25
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf marked this pull request as ready for review July 26, 2024 09:31
@elianalf elianalf added the skip-ci Automatically pass CI label Jul 26, 2024
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review (style mainly).
Pending deep review about the exposed content (check that there is nothing missing to be exposed in this guide)

UPGRADING.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
UPGRADING.md Show resolved Hide resolved
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
UPGRADING.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
UPGRADING.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
UPGRADING.md Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@EduPonz EduPonz dismissed JesusPoderoso’s stale review July 30, 2024 06:49

Changes have been applied and reviewed

@EduPonz EduPonz merged commit 9295047 into master Jul 30, 2024
3 checks passed
@EduPonz EduPonz deleted the migration_guide branch July 30, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants