-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21363] Migration guide #5102
Merged
Merged
[21363] Migration guide #5102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elianalf
force-pushed
the
migration_guide
branch
2 times, most recently
from
July 24, 2024 14:43
3585ed0
to
526f0bc
Compare
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
elianalf
force-pushed
the
migration_guide
branch
from
July 26, 2024 09:16
526f0bc
to
588e7b3
Compare
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
JesusPoderoso
previously requested changes
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review (style mainly).
Pending deep review about the exposed content (check that there is nothing missing to be exposed in this guide)
elianalf
force-pushed
the
migration_guide
branch
from
July 29, 2024 11:04
3c41c45
to
fe7a0b9
Compare
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
elianalf
force-pushed
the
migration_guide
branch
from
July 29, 2024 11:05
fe7a0b9
to
d5df1c1
Compare
EduPonz
suggested changes
Jul 29, 2024
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
EduPonz
suggested changes
Jul 30, 2024
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
EduPonz
approved these changes
Jul 30, 2024
EduPonz
dismissed
JesusPoderoso’s stale review
July 30, 2024 06:49
Changes have been applied and reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Upgrading.md document, which aims to help during the migration process from eProsima Fast DDS version 2 to Fast DDS version 3.
It contains the changes that a user may need to apply to migrate to Fast DDS v3.0.0.
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist