[21327] Mitigate LogTests.flush_n flakiness (backport #5051)
#5064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Refs #21327: Fix LogTests.flush_n flakiness Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21327: TODO DROP THIS: add colcon test Dispatch argument Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Revert "Refs #21327: TODO DROP THIS: add colcon test Dispatch argument" This reverts commit 48084a2. Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com> (cherry picked from commit 77768eb)
10 tasks
JesusPoderoso
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR mitigates the flakiness of the
LogTests.flush_n. Analysis showed that the conditions to assure thatLog::Flush()is correctly synchronised with running exactly two times theLog::Run()were not fully correct. This PR tackles that and refactor the comments.Reviewer can test running the test multiple times
@Mergifyio backport 2.14.x 2.10.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A New feature has been added to the
versions.mdfile (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #5051 done by [Mergify](https://mergify.com).