[21233] Mitigate buffer recover test flakiness on mac #5035

Mario-DL · 2024-07-07T21:32:40Z

Description

This PR tries to mitigate the buffer_recover test flakiness in mac, further explanation is included in the comments within the code.

@Mergifyio backport 2.14.x 2.13.x 2.10.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
If this is a critical bug fix, backports to the critical-only supported branches have been requested.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Mario Domínguez López <mariodominguez@eprosima.com>

test/unittest/transport/SharedMemTests.cpp

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

test/unittest/transport/SharedMemTests.cpp

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

elianalf · 2024-07-10T08:24:44Z

LGTM with green CI.
After manual CI (run with --repeat-until-fail 30) passes we should remove the first commit introduced for debugging

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

This reverts commit d3e71c9.

This reverts commit cbc2aa1.

EduPonz · 2024-07-11T10:33:57Z

CI on the modified test run 30 times without failure here

EduPonz · 2024-07-11T10:35:07Z

@Mergifyio backport 2.14.x 2.10.x

mergify · 2024-07-11T10:35:21Z

backport 2.14.x 2.10.x

✅ Backports have been created

#5058 [21233] Mitigate buffer recover test flakiness on mac (backport #5035) has been created for branch 2.14.x
#5059 [21233] Mitigate buffer recover test flakiness on mac (backport #5035) has been created for branch 2.10.x

* Refs #21233: Run mac-ci only and buffer recover test Signed-off-by: Mario Domínguez López <mariodominguez@eprosima.com> * Refs #21233: Test fix Signed-off-by: Mario Domínguez López <mariodominguez@eprosima.com> * Refs #21233: Apply Elianas sugg Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21233: Apply Miguels sugg Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21233: TMP force multiple test runs Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Revert "Refs #21233: TMP force multiple test runs" This reverts commit d3e71c9. * Revert "Refs #21233: Run mac-ci only and buffer recover test" This reverts commit cbc2aa1. --------- Signed-off-by: Mario Domínguez López <mariodominguez@eprosima.com> Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit af92c13)

* Refs #21233: Run mac-ci only and buffer recover test Signed-off-by: Mario Domínguez López <mariodominguez@eprosima.com> * Refs #21233: Test fix Signed-off-by: Mario Domínguez López <mariodominguez@eprosima.com> * Refs #21233: Apply Elianas sugg Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21233: Apply Miguels sugg Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21233: TMP force multiple test runs Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Revert "Refs #21233: TMP force multiple test runs" This reverts commit d3e71c9. * Revert "Refs #21233: Run mac-ci only and buffer recover test" This reverts commit cbc2aa1. --------- Signed-off-by: Mario Domínguez López <mariodominguez@eprosima.com> Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit af92c13) Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>

* Refs #21233: Run mac-ci only and buffer recover test Signed-off-by: Mario Domínguez López <mariodominguez@eprosima.com> * Refs #21233: Test fix Signed-off-by: Mario Domínguez López <mariodominguez@eprosima.com> * Refs #21233: Apply Elianas sugg Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21233: Apply Miguels sugg Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21233: TMP force multiple test runs Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Revert "Refs #21233: TMP force multiple test runs" This reverts commit d3e71c9. * Revert "Refs #21233: Run mac-ci only and buffer recover test" This reverts commit cbc2aa1. --------- Signed-off-by: Mario Domínguez López <mariodominguez@eprosima.com> Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit af92c13)

* Refs #21233: Run mac-ci only and buffer recover test Signed-off-by: Mario Domínguez López <mariodominguez@eprosima.com> * Refs #21233: Test fix Signed-off-by: Mario Domínguez López <mariodominguez@eprosima.com> * Refs #21233: Apply Elianas sugg Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21233: Apply Miguels sugg Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21233: TMP force multiple test runs Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Revert "Refs #21233: TMP force multiple test runs" This reverts commit d3e71c9. * Revert "Refs #21233: Run mac-ci only and buffer recover test" This reverts commit cbc2aa1. --------- Signed-off-by: Mario Domínguez López <mariodominguez@eprosima.com> Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit af92c13) Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>

Refs #21233: Run mac-ci only and buffer recover test

cbc2aa1

Signed-off-by: Mario Domínguez López <mariodominguez@eprosima.com>

Mario-DL added this to the v3.0.0 milestone Jul 7, 2024

EduPonz requested a review from elianalf July 8, 2024 04:57

github-actions bot added the ci-pending PR which CI is running label Jul 8, 2024

Mario-DL force-pushed the bugfix/21233 branch from a662fbe to 199ca21 Compare July 8, 2024 07:32

Mario-DL requested review from elianalf and removed request for elianalf July 8, 2024 07:32

Refs #21233: Test fix

f690d11

Signed-off-by: Mario Domínguez López <mariodominguez@eprosima.com>

Mario-DL force-pushed the bugfix/21233 branch from 199ca21 to f690d11 Compare July 8, 2024 08:34

Mario-DL requested review from elianalf and removed request for elianalf July 8, 2024 08:34

elianalf requested review from elianalf and removed request for elianalf July 9, 2024 07:54

elianalf suggested changes Jul 10, 2024

View reviewed changes

test/unittest/transport/SharedMemTests.cpp Show resolved Hide resolved

Refs #21233: Apply Elianas sugg

69d5a6d

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Mario-DL requested a review from elianalf July 10, 2024 08:07

MiguelCompany requested changes Jul 10, 2024

View reviewed changes

test/unittest/transport/SharedMemTests.cpp Outdated Show resolved Hide resolved

Refs #21233: Apply Miguels sugg

e5e88e4

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Mario-DL requested review from elianalf and removed request for elianalf July 10, 2024 08:13

MiguelCompany previously approved these changes Jul 10, 2024

View reviewed changes

Mario-DL dismissed MiguelCompany’s stale review via 2d38ee6 July 10, 2024 13:58

Mario-DL requested review from elianalf and removed request for elianalf July 10, 2024 13:58

Mario-DL force-pushed the bugfix/21233 branch from 2d38ee6 to 614c10c Compare July 10, 2024 19:52

Mario-DL requested review from elianalf and removed request for elianalf July 10, 2024 19:52

Mario-DL force-pushed the bugfix/21233 branch from 614c10c to 0e4dca1 Compare July 11, 2024 07:23

Mario-DL requested review from elianalf and removed request for elianalf July 11, 2024 07:23

Refs #21233: TMP force multiple test runs

d3e71c9

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Mario-DL force-pushed the bugfix/21233 branch from 0e4dca1 to d3e71c9 Compare July 11, 2024 08:05

Mario-DL requested review from elianalf and removed request for elianalf July 11, 2024 08:05

Mario-DL added 2 commits July 11, 2024 12:06

Revert "Refs #21233: TMP force multiple test runs"

5f19513

This reverts commit d3e71c9.

Revert "Refs #21233: Run mac-ci only and buffer recover test"

9e1aa6f

This reverts commit cbc2aa1.

elianalf approved these changes Jul 11, 2024

View reviewed changes

elianalf added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Jul 11, 2024

EduPonz merged commit af92c13 into master Jul 11, 2024
3 checks passed

EduPonz deleted the bugfix/21233 branch July 11, 2024 10:34

mergify bot mentioned this pull request Jul 11, 2024

[21233] Mitigate buffer recover test flakiness on mac (backport #5035) #5058

Merged

12 tasks

mergify bot mentioned this pull request Jul 11, 2024

[21233] Mitigate buffer recover test flakiness on mac (backport #5035) #5059

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[21233] Mitigate buffer recover test flakiness on mac #5035

[21233] Mitigate buffer recover test flakiness on mac #5035

Mario-DL commented Jul 7, 2024 •

edited by elianalf

Loading

elianalf commented Jul 10, 2024 •

edited

Loading

EduPonz commented Jul 11, 2024

EduPonz commented Jul 11, 2024

mergify bot commented Jul 11, 2024 •

edited

Loading

[21233] Mitigate buffer recover test flakiness on mac #5035

[21233] Mitigate buffer recover test flakiness on mac #5035

Conversation

Mario-DL commented Jul 7, 2024 • edited by elianalf Loading

Description

Contributor Checklist

Reviewer Checklist

elianalf commented Jul 10, 2024 • edited Loading

EduPonz commented Jul 11, 2024

EduPonz commented Jul 11, 2024

mergify bot commented Jul 11, 2024 • edited Loading

✅ Backports have been created

Mario-DL commented Jul 7, 2024 •

edited by elianalf

Loading

elianalf commented Jul 10, 2024 •

edited

Loading

mergify bot commented Jul 11, 2024 •

edited

Loading