Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20815] Fix doxygen warning about undocumented param in deleted functions #4918

Merged
merged 2 commits into from
Jun 10, 2024
Merged

[20815] Fix doxygen warning about undocumented param in deleted functions #4918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f68ad1f
Refs #20815: Avoid doxygen warning about undocumented param in delete…
EduPonz Jun 8, 2024
119cdbd
Refs #20815: Rename some targets to be able to compile with thirdparty
EduPonz Jun 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ if(BUILD_DOCUMENTATION)
endif()

# Target to create documentation directories
add_custom_target(docdirs
add_custom_target(fastdds_docdirs
COMMAND ${CMAKE_COMMAND} -E make_directory ${PROJECT_BINARY_DIR}/doc
COMMENT "Creating documentation directory" VERBATIM)

Expand All @@ -479,12 +479,12 @@ if(BUILD_DOCUMENTATION)
# Configure the template doxyfile for or specific project
configure_file(doxyfile.in ${PROJECT_BINARY_DIR}/doxyfile @ONLY IMMEDIATE)
# Add custom target to run doxygen when ever the project is build
add_custom_target(doxygen
add_custom_target(fastdds_doxygen
COMMAND "${DOXYGEN_EXECUTABLE}" "${PROJECT_BINARY_DIR}/doxyfile"
SOURCES "${PROJECT_BINARY_DIR}/doxyfile"
COMMENT "Generating API documentation with doxygen" VERBATIM)

add_dependencies(doxygen docdirs)
add_dependencies(fastdds_doxygen fastdds_docdirs)

### README html ########################

Expand Down Expand Up @@ -535,15 +535,15 @@ if(BUILD_DOCUMENTATION)
COMMAND ${CMAKE_COMMAND} -P ${CMAKE_CURRENT_BINARY_DIR}/readthedocs_custom.cmake
)

add_dependencies(readthedocs docdirs)
add_dependencies(readthedocs fastdds_docdirs)
endif()

add_custom_target(doc ALL
add_custom_target(fastdds_docs ALL
COMMENT "Generated project documentation" VERBATIM)

add_dependencies(doc doxygen)
add_dependencies(fastdds_docs fastdds_doxygen)
if(NOT CHECK_DOCUMENTATION)
add_dependencies(doc readthedocs)
add_dependencies(fastdds_docs readthedocs)
endif()
endif()

Expand Down
18 changes: 4 additions & 14 deletions include/fastrtps/types/DynamicLoanableSequence.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,27 +91,17 @@ class LoanableSequence<fastrtps::types::DynamicData, _NonConstEnabler>

/// Deleted copy constructor for LoanableSequence.
LoanableSequence(
const LoanableSequence& other) = delete;
const LoanableSequence&) = delete;

/// Deleted copy assignment operator for LoanableSequence.
LoanableSequence& operator =(
const LoanableSequence& other) = delete;
const LoanableSequence&) = delete;

/**
* @brief Move constructor for LoanableSequence.
*
* @param[in] other The other LoanableSequence to move from.
*/
/// Move constructor for LoanableSequence.
LoanableSequence(
LoanableSequence&&) = default;

/**
* @brief Move assignment operator for LoanableSequence.
*
* @param[in] other The other LoanableSequence to move from.
*
* @return A reference to this LoanableSequence.
*/
/// Move assignment operator for LoanableSequence.
LoanableSequence& operator =(
LoanableSequence&&) = default;

Expand Down
Loading