Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20989] Don't require Fast CDR v2 in examples (backport #4833) #4834

Merged
merged 1 commit into from
May 23, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 23, 2024

Description

This PR removes the restriction of Fast CDR to be version 2 for examples, as they are prepared to also work with Fast CDR v1.

@Mergifyio backport 2.13.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • The code follows the style guidelines of this project.

  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A: Any new/modified methods have been properly documented using Doxygen.

  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • N/A: Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • N/A: Changes are API compatible.

  • N/A: New feature has been added to the versions.md file (if applicable).

  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #4833 done by [Mergify](https://mergify.com).

Signed-off-by: eduponz <eduardoponz@eprosima.com>
(cherry picked from commit fc576e4)
@JesusPoderoso JesusPoderoso added this to the v2.13.5 milestone May 23, 2024
@JesusPoderoso JesusPoderoso self-assigned this May 23, 2024
@JesusPoderoso JesusPoderoso added the no-test Skip CI tests if PR marked with this label label May 23, 2024
@JesusPoderoso JesusPoderoso self-requested a review May 23, 2024 09:49
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the ci-pending PR which CI is running label May 23, 2024
@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels May 23, 2024
@EduPonz EduPonz merged commit a904d84 into 2.13.x May 23, 2024
9 checks passed
@EduPonz EduPonz deleted the mergify/bp/2.13.x/pr-4833 branch May 23, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-test Skip CI tests if PR marked with this label ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants