Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20652] Add DNS entries to hosts files on github workflows (backport #4776) #4810

Merged
merged 1 commit into from
May 21, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 20, 2024

Description

Windows github workflow is writing the hosts file so the tests using DNS can be run.
This PR writes the /etc/hosts file using sudo tee -a on Ubuntu, Sanitizers, and Mac workflows.

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • N/A The code follows the style guidelines of this project.

  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A Any new/modified methods have been properly documented using Doxygen.

  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are ABI compatible.

  • Changes are API compatible.

  • N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #4776 done by [Mergify](https://mergify.com).

* Refs #20652. Write hosts file on reusable-ubuntu-ci.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20652. Write hosts file on reusable-sanitizers-ci.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20652. Write hosts file on reusable-mac-ci.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20652. Apply review suggestions.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 625b041)
@JesusPoderoso JesusPoderoso added this to the v2.10.4 milestone May 20, 2024
@MiguelCompany MiguelCompany self-requested a review May 20, 2024 07:53
@github-actions github-actions bot added the ci-pending PR which CI is running label May 20, 2024
@MiguelCompany MiguelCompany merged commit e36f6b8 into 2.10.x May 21, 2024
7 of 12 checks passed
@MiguelCompany MiguelCompany deleted the mergify/bp/2.10.x/pr-4776 branch May 21, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants