Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21009] Do not require PYTHON_VERSION to be defined in .bat files (backport #4770) #4797

Merged
merged 1 commit into from
May 20, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 17, 2024

Description

@MiguelCompany identified an error introduced in #4759 as the PYTHON_VERSION does not necessarily need to be defined when executing the fastdds.bat or ros-discovery.bat scripts.
The change simply requires a specific version of Python only if PYTHON_VERSION is defined.

Tested on Windows.

@Mergifyio backport 2.14.x 2.13.x

Cherry-pick on #4765 and #4766

Contributor Checklist

  • Commit messages follow the project guidelines.

  • The code follows the style guidelines of this project.

  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A Any new/modified methods have been properly documented using Doxygen.

  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are ABI compatible.

  • Changes are API compatible.

  • N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A Check CI results: changes do not issue any warning.
  • N/A Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #4770 done by [Mergify](https://mergify.com).

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 39e8957)
@MiguelCompany MiguelCompany self-requested a review May 17, 2024 05:39
@MiguelCompany MiguelCompany added this to the v2.14.2 milestone May 17, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label May 17, 2024
@EduPonz EduPonz self-requested a review May 17, 2024 12:13
@EduPonz EduPonz merged commit 6a6ae64 into 2.14.x May 20, 2024
11 of 21 checks passed
@EduPonz EduPonz deleted the mergify/bp/2.14.x/pr-4770 branch May 20, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants