[20742] Run is_plain method with the corresponding data representation (backport #4681)
#4757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Refs #20742: Add regression tests for endpoints Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20742: Run method with the corresponding data representation Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20742: Set SampleLoanManager variable with property value Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20574: Please linter Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20742: Check `is_plain` for all possible DataReader's data representation Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20742: Fix failures in other tests Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20742: Fix unset datarepresentation case Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20742: Add Miguel' suggestion Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20742: Apply rev suggestions Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20742: Please linter Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> (cherry picked from commit aef4f43)
11 tasks
JesusPoderoso
approved these changes
May 8, 2024
|
@richiprosima please test this |
JesusPoderoso
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The endpoints implementation (DataReaderImpl and DataWriterImpl) were calling
is_plainmethod without the data representation, so it was not being considered.This PR includes the data representation as an argument to
is_plainso it is considered in both cases.@Mergifyio backport 2.13.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are ABI compatible.
Changes are API compatible.
N/A New feature has been added to the
versions.mdfile (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #4681 done by [Mergify](https://mergify.com).