Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address compilation issue for GLIBC version prior to 2.30 #4753

Conversation

manuelValch
Copy link
Contributor

@manuelValch manuelValch commented May 5, 2024

Description

Fixes:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • NO Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally <!-- Blackbox tests checking the new functionality are required. Changes that add/modify public API must include unit tests covering all possible cases. In case that no tests are provided, please justify why.

No test provided as it is only to add possibility to compile on previous GLIBC version.

  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are ABI compatible.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@manuelValch manuelValch force-pushed the 4225-Fast-DDS-Oracle8.4-compilation-issue branch from fd67a9b to cbf0302 Compare May 5, 2024 18:57
If this commit is applied then distribution with GLIBC version
< 2.30 will be able to compiled Fast-DDS.

defined gettid as a syscall to SYS_gettid.

Signed-off-by: Manuel Valch <manuelValch@proton.me>
@manuelValch manuelValch force-pushed the 4225-Fast-DDS-Oracle8.4-compilation-issue branch from cbf0302 to 4c2922a Compare May 5, 2024 18:58
@elianalf elianalf self-requested a review May 7, 2024 09:45
@MiguelCompany MiguelCompany added the no-test Skip CI tests if PR marked with this label label May 7, 2024
@MiguelCompany
Copy link
Member

@richiprosima Please test this

@EduPonz EduPonz added this to the v2.14.1 milestone May 8, 2024
@EduPonz EduPonz merged commit af75423 into eProsima:master May 8, 2024
10 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-test Skip CI tests if PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants