Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20732] Fix some leaks in XML DynamicTypes Parser (backport #4717) #4736

Closed
wants to merge 1 commit into from

Commits on Apr 26, 2024

  1. Fix some leaks in XML DynamicTypes Parser (#4717)

    * Refs #20732. Add regression test.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20732. Fixes on parseXMLAliasDynamicType.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20732. Fixes on parseXMLBitsetDynamicType.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20732. Fixes on parseXMLBitmaskDynamicType.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20732. Fixes on parseXMLEnumDynamicType.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20732. Fixes on parseXMLStructDynamicType.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20732. Fixes on parseXMLUnionDynamicType.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20372. Return error when `insertDynamicTypeByName` fails.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20372. Fail parsing for empty name attributes.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20732. Move implementation of `DeleteInstance` to source file.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20732. Delete registered dynamic type builders in `XMLProfileManager::DeleteInstance()`.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    ---------
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    (cherry picked from commit 8cb447b)
    
    # Conflicts:
    #	include/fastrtps/xmlparser/XMLProfileManager.h
    #	test/unittest/xmlparser/XMLParserTests.cpp
    MiguelCompany authored and mergify[bot] committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    a204d2b View commit details
    Browse the repository at this point in the history