Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20819] Make TimedEvent private #4727

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Apr 25, 2024

Description

This PR makes TimedEvent.h private

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are ABI compatible.
  • ❌ Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@elianalf elianalf added this to the v3.0.0 milestone Apr 25, 2024
@elianalf elianalf added the needs-review PR that is ready to be reviewed label Apr 29, 2024
@EduPonz EduPonz force-pushed the 3.0.x-devel branch 2 times, most recently from 08ee62b to 623db82 Compare May 13, 2024 09:26
@EduPonz EduPonz deleted the branch master May 14, 2024 07:22
@EduPonz EduPonz closed this May 14, 2024
@EduPonz EduPonz reopened this May 14, 2024
@EduPonz EduPonz changed the base branch from 3.0.x-devel to master May 14, 2024 07:27
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf force-pushed the feature/make_timedevent_private branch from f0686af to 7b540c1 Compare May 21, 2024 14:27
@github-actions github-actions bot added the ci-pending PR which CI is running label May 21, 2024
@elianalf
Copy link
Contributor Author

@richiprosima test linux

@JesusPoderoso JesusPoderoso requested review from JesusPoderoso and removed request for JesusPoderoso May 21, 2024 14:37
@JesusPoderoso JesusPoderoso removed the needs-review PR that is ready to be reviewed label May 21, 2024
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@elianalf
Copy link
Contributor Author

@richiprosima please test_3 this

@elianalf
Copy link
Contributor Author

@richiprosima test windows

@elianalf elianalf added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label May 22, 2024
@EduPonz EduPonz merged commit 55fdaf6 into master May 22, 2024
15 of 26 checks passed
@EduPonz EduPonz deleted the feature/make_timedevent_private branch May 22, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants