Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20750] Add check for XML API to PR template #4658

Merged
merged 1 commit into from
Apr 4, 2024
Merged

[20750] Add check for XML API to PR template #4658

merged 1 commit into from
Apr 4, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Apr 4, 2024 •
edited by JesusPoderoso
Loading

Description

This PR adds a check for the PRs to add XML API if needed.

@Mergifyio backport 2.13.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are ABI compatible.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz
Refs #20750: Add check for XML API to PR template
efd93fd 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz added this to the v2.14.1 milestone Apr 4, 2024
@EduPonz EduPonz added the skip-ci Automatically pass CI label Apr 4, 2024
@EduPonz EduPonz marked this pull request as ready for review April 4, 2024 12:41
JesusPoderoso
JesusPoderoso approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JesusPoderoso
Copy link
Contributor

@richiprosima please test this

@JesusPoderoso JesusPoderoso requested review from JesusPoderoso and removed request for JesusPoderoso April 4, 2024 12:45
@EduPonz
Copy link
Author

EduPonz commented Apr 4, 2024

@Mergifyio backport 2.13.x 2.10.x 2.6.x

@EduPonz EduPonz merged commit 5eeee69 into master Apr 4, 2024
3 checks passed
@EduPonz EduPonz deleted the gh/improve_checklist branch April 4, 2024 12:50
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 4, 2024 •
edited
Loading

backport 2.13.x 2.10.x 2.6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 4, 2024
@EduPonz @mergify
Add check for XML API to PR template (#4658)
1bbc1c3 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
(cherry picked from commit 5eeee69)
@mergify mergify bot mentioned this pull request Apr 4, 2024
Merged
7 tasks
mergify bot pushed a commit that referenced this pull request Apr 4, 2024
@EduPonz @mergify
Add check for XML API to PR template (#4658)
381eb6b 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
(cherry picked from commit 5eeee69)
mergify bot pushed a commit that referenced this pull request Apr 4, 2024
@EduPonz @mergify
Add check for XML API to PR template (#4658)
a5e9815 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
(cherry picked from commit 5eeee69)

# Conflicts:
#	.github/pull_request_template.md
This was referenced Apr 4, 2024
Merged
Merged
@Mario-DL Mario-DL added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. labels Apr 10, 2024
MiguelCompany pushed a commit that referenced this pull request Apr 15, 2024
@mergify @EduPonz
Add check for XML API to PR template (#4658) (#4660)
748f85e 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
(cherry picked from commit 5eeee69)

Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
EduPonz added a commit that referenced this pull request Apr 16, 2024
@mergify @EduPonz @Mario-DL
Add check for XML API to PR template (#4658) (#4661)
0439847 
* Add check for XML API to PR template (#4658)

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
(cherry picked from commit 5eeee69)

# Conflicts:
#	.github/pull_request_template.md

* Refs #20703: Fix conflicts

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Co-authored-by: Mario Dominguez <mariodominguez@eprosima.com>
EduPonz added a commit that referenced this pull request Apr 17, 2024
@mergify @EduPonz
Add check for XML API to PR template (#4658) (#4659)
66e9760 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
(cherry picked from commit 5eeee69)

Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
skip-ci Automatically pass CI
Projects
None yet
Milestone
v2.14.1
Development

Successfully merging this pull request may close these issues.
3 participants
@EduPonz @JesusPoderoso @Mario-DL