Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20672] Use a plain switch for NetmaskFilterKind std::ostream& operator<< #4587

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Mar 20, 2024

Description

This PR refactors the std::ostream& operator << so that it uses a plain switch instead of an unordered map, since the previous implementation was failing to compile under some compilers clang 15 because the enum class does not define any hashing function. It seems that our supported compilers could deduce that the enum class was in fact an int and that's why it did not get detected on CI.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz added needs-review PR that is ready to be reviewed ci-pending PR which CI is running labels Mar 20, 2024
@EduPonz EduPonz added this to the v2.14.1 milestone Mar 20, 2024
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany removed the needs-review PR that is ready to be reviewed label Mar 20, 2024
@EduPonz
Copy link
Author

EduPonz commented Mar 20, 2024

@richiprosima please test this

@EduPonz EduPonz merged commit 1551fd0 into master Mar 21, 2024
13 of 15 checks passed
@EduPonz EduPonz deleted the hotfix/oss-fuzz-build branch March 21, 2024 06:38
@EduPonz EduPonz removed the ci-pending PR which CI is running label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants