Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20662] Select reusable workflow version depending on target branch in nightly jobs #4581

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Mar 19, 2024

Description

This PR updates the nightly jobs to select the reusable workflow version depending on the branch tested. Sadly, uses keyword is context agnostic, so the version cannot be taken from the fastdds-branch matrix. Instead, a separate specific job for each tested version needs to be created. Furthermore, this PR makes the security option a matrix parameter, so both ON and OFF configurations are run for all versions in all platforms.

A manually triggered job can be seen here.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Changes are ABI compatible.
  • N/A: Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

…nch in nightly jobs

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz added the skip-ci Automatically pass CI label Mar 19, 2024
@EduPonz EduPonz added this to the v2.14.0 - Frozen milestone Mar 19, 2024
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LRGTM!

@EduPonz EduPonz merged commit a146b23 into master Mar 19, 2024
9 of 21 checks passed
@EduPonz EduPonz deleted the hotfix/select_nightly_workflows branch March 19, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants