Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20553] Set 2.12.x as EOL #4559

Merged
merged 2 commits into from
Mar 20, 2024
Merged

[20553] Set 2.12.x as EOL #4559

merged 2 commits into from
Mar 20, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Mar 15, 2024

Description

This PR marks 2.12.x as an end-of-life version, by:

  • removing it from backports list in the pull request template
  • removing it from the nightly CI
  • removing the bold mark in the supported versions MD

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Changes are ABI compatible.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
    Related documentation PR: [20553] Set 2.12.x as EOL Fast-DDS-docs#733
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added the skip-ci Automatically pass CI label Mar 15, 2024
@JesusPoderoso JesusPoderoso added this to the v2.14.1 milestone Mar 15, 2024
@JesusPoderoso
Copy link
Contributor Author

@richiprosima please test this

@JesusPoderoso JesusPoderoso added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Mar 18, 2024
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR should also remove 2.12.x from:

  • Nightly CI
  • RELEASE_SUPPORT.md (should not be bolded anymore)

@EduPonz EduPonz added to-do and removed ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. labels Mar 20, 2024
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso force-pushed the feature/remove_2.12.x_PRtemplate branch from 3a04876 to 741cdc9 Compare March 20, 2024 06:42
@JesusPoderoso JesusPoderoso added doc-pending Issue or PR which is pending to be documented and removed to-do labels Mar 20, 2024
@JesusPoderoso JesusPoderoso removed the doc-pending Issue or PR which is pending to be documented label Mar 20, 2024
@JesusPoderoso JesusPoderoso changed the title [20553] Remove 2.12.x from PR template backports [20553] Set 2.12.x as EOL Mar 20, 2024
@EduPonz EduPonz merged commit 42340ea into master Mar 20, 2024
9 checks passed
@EduPonz EduPonz deleted the feature/remove_2.12.x_PRtemplate branch March 20, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants