Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20187] Add catch of out-of-range exception for thread settings port #4461

Merged
merged 2 commits into from
Feb 29, 2024
Merged

[20187] Add catch of out-of-range exception for thread settings port #4461

merged 2 commits into from
Feb 29, 2024

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Feb 27, 2024 •
edited
Loading

Description

When a value out of the range is assigned to the attribute port of thread_settings, an exception was thrown but not catched. This PR adds a catch of out-of-range exception and a regression test.

@Mergifyio backport 2.13.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@elianalf
Refs #20187: Add catch of out-of-range exception for thread settings …
2f04362 
…port

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf changed the title Refs #20187: Add catch of out-of-range exception for thread settings … [20187] Add catch of out-of-range exception for thread settings port Feb 27, 2024
@elianalf elianalf added the no-test Skip CI tests if PR marked with this label label Feb 27, 2024
@elianalf elianalf added this to the v2.14.0 milestone Feb 27, 2024
@EduPonz
Copy link

EduPonz commented Feb 28, 2024

@richiprosima please test linux test discovery-server

@EduPonz EduPonz added ci-pending PR which CI is running and removed no-test Skip CI tests if PR marked with this label labels Feb 28, 2024
EduPonz
EduPonz reviewed Feb 28, 2024
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. I'll approve onces uncrustify passes

@elianalf
Refs #20187: Uncrustify
5a1a5bf 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf added skip-ci Automatically pass CI and removed skip-ci Automatically pass CI labels Feb 28, 2024
@EduPonz
Copy link

EduPonz commented Feb 28, 2024

@Mergifyio backport 2.13.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 28, 2024 •
edited
Loading

backport 2.13.x

✅ Backports have been created

@EduPonz EduPonz merged commit a907798 into master Feb 29, 2024
9 of 12 checks passed
@EduPonz EduPonz deleted the hotfix/add_try_catch_XMLProfiles branch February 29, 2024 07:10
mergify bot pushed a commit that referenced this pull request Feb 29, 2024
@elianalf @mergify
Add catch of out-of-range exception for thread settings port (#4461)
a3a8c75 
* Refs #20187: Add catch of out-of-range exception for thread settings port

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20187: Uncrustify

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

---------

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
(cherry picked from commit a907798)
@mergify mergify bot mentioned this pull request Feb 29, 2024
Merged
EduPonz pushed a commit that referenced this pull request Mar 22, 2024
@mergify @elianalf
Add catch of out-of-range exception for thread settings port (#4461) (#…
11e1e3e 
…4472)

* Refs #20187: Add catch of out-of-range exception for thread settings port

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20187: Uncrustify

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

---------

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
(cherry picked from commit a907798)

Co-authored-by: elianalf <62831776+elianalf@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v2.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@elianalf @EduPonz