Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20165] Add tests for TypeLookup service #4339

Merged
merged 45 commits into from
Sep 25, 2024
Merged

Conversation

adriancampo
Copy link
Contributor

@adriancampo adriancampo commented Jan 31, 2024

This PR adds:
Comunication tests for the TypeLookup service
Negative unit tests cases for the TypeLookup service

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • [N/A] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [N/A] Any new/modified methods have been properly documented using Doxygen.
  • [N/A] Changes are ABI compatible.
  • [N/A] Changes are API compatible.
  • [N/A] New feature has been added to the versions.md file (if applicable).
  • [N/A] New feature has been documented/Current behavior is correctly described in the documentation.
  • [N/A] Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@adriancampo adriancampo added the no-test Skip CI tests if PR marked with this label label Jan 31, 2024
@adriancampo adriancampo marked this pull request as ready for review February 1, 2024 11:05
@adriancampo adriancampo force-pushed the feature/typelookup-test branch 3 times, most recently from 09ff409 to 5562797 Compare February 12, 2024 15:25
@adriancampo adriancampo force-pushed the feature/typelookup-test branch 3 times, most recently from 070b1cd to 1bd6739 Compare February 19, 2024 15:06
@adriancampo adriancampo changed the base branch from feature/typelookup-listeners-implementation to feature/xtypes1.3 February 20, 2024 11:47
@EduPonz EduPonz added this to the v3.0.0 milestone Feb 21, 2024
@adriancampo adriancampo changed the base branch from feature/xtypes1.3 to feature/typelookup-listeners-implementation February 22, 2024 20:48
@adriancampo adriancampo force-pushed the feature/typelookup-test branch 2 times, most recently from a677d15 to 96bc6ff Compare February 23, 2024 10:34
@adriancampo adriancampo force-pushed the feature/typelookup-listeners-implementation branch 3 times, most recently from b0e9647 to 99b6430 Compare February 28, 2024 06:50
@adriancampo adriancampo changed the base branch from feature/typelookup-listeners-implementation to feature/tests_for_dds_types_test February 28, 2024 16:17
@adriancampo adriancampo changed the base branch from feature/tests_for_dds_types_test to feature/typelookup-listeners-implementation February 28, 2024 16:18
@adriancampo adriancampo force-pushed the feature/typelookup-listeners-implementation branch from 99b6430 to e03974e Compare March 6, 2024 14:28
@adriancampo adriancampo force-pushed the feature/typelookup-listeners-implementation branch from c9f8320 to f4e2ae9 Compare March 7, 2024 10:18
@adriancampo adriancampo force-pushed the feature/typelookup-listeners-implementation branch 2 times, most recently from 34997c9 to 8154de5 Compare March 18, 2024 15:00
adriancampo and others added 19 commits September 24, 2024 09:01
Signed-off-by: adriancampo <adriancampo@eprosima.com>
Signed-off-by: adriancampo <adriancampo@eprosima.com>
Signed-off-by: adriancampo <adriancampo@eprosima.com>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI.

@richiware richiware merged commit 309ae6f into master Sep 25, 2024
16 of 17 checks passed
@richiware richiware deleted the feature/typelookup-test branch September 25, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants