-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20121] Remove unnecessary TCP warning & Fix some tests (backport #4217) #4275
Conversation
ead7e94
to
a37133e
Compare
@richiprosima please test linux please test mac |
@richiprosima please test linux test mac |
@jepemi same also here |
Signed-off-by: Jesus Perez <jesusperez@eprosima.com> (cherry picked from commit ab94226)
a37133e
to
796d5a6
Compare
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
I am going ahead and take advantage of this PR to include a couple of commits that fix some of the failing tests of the |
@richiprosima please test linux test discovery_server |
Failing tests on Windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is an automatic backport of pull request #4217 done by Mergify.
Cherry-pick of ab94226 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com