Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20262] Fix wrong log info messages on TCP #4258

Merged
merged 1 commit into from
Jan 22, 2024
Merged

[20262] Fix wrong log info messages on TCP #4258

merged 1 commit into from
Jan 22, 2024

Conversation

jepemi
Copy link
Contributor

@jepemi jepemi commented Jan 18, 2024 •
edited by MiguelCompany
Loading

Description

Previously, when a message was received, the log info messages incorrectly displayed that it was received from a UDP locator with an invalid address. Additionally, upon accepting a connection, log info also reported a local locator with an invalid address.
Both behaviors have been rectified by generating a locator using the information provided by the socket.

@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@jepemi
Refs #20262: Fix wrong log info messages
3beb75f 
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
@MiguelCompany MiguelCompany added this to the v2.13.2 milestone Jan 18, 2024
MiguelCompany
MiguelCompany approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, and I am approving this, but the title and description should better depict the purpose of the PR

@MiguelCompany MiguelCompany added the ci-pending PR which CI is running label Jan 18, 2024
@MiguelCompany MiguelCompany changed the title [20262] TCP Fix wrong log info messages [20262] Fix wrong log info messages on TCP Jan 18, 2024
@MiguelCompany MiguelCompany merged commit 36f7f57 into master Jan 22, 2024
10 of 14 checks passed
@MiguelCompany MiguelCompany deleted the bugfix/tcp_wrong_receive_log_info branch January 22, 2024 14:36
@EduPonz
Copy link

EduPonz commented Jan 27, 2024

@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 27, 2024 •
edited
Loading

backport 2.12.x 2.11.x 2.10.x 2.6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 27, 2024
@jepemi @mergify
Fix wrong log info messages on TCP (#4258)
437d081 
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
(cherry picked from commit 36f7f57)
This was referenced Jan 27, 2024
Merged
Merged
mergify bot pushed a commit that referenced this pull request Jan 27, 2024
@jepemi @mergify
Fix wrong log info messages on TCP (#4258)
31b1470 
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
(cherry picked from commit 36f7f57)

# Conflicts:
#	src/cpp/rtps/transport/TCPTransportInterface.cpp
@mergify mergify bot mentioned this pull request Jan 27, 2024
Merged
mergify bot pushed a commit that referenced this pull request Jan 27, 2024
@jepemi @mergify
Fix wrong log info messages on TCP (#4258)
19634fb 
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
(cherry picked from commit 36f7f57)

# Conflicts:
#	src/cpp/rtps/transport/TCPTransportInterface.cpp
@mergify mergify bot mentioned this pull request Jan 27, 2024
Merged
@JesusPoderoso JesusPoderoso added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Jan 29, 2024
@jepemi jepemi mentioned this pull request Jan 29, 2024
Merged
12 tasks
MiguelCompany pushed a commit that referenced this pull request Feb 1, 2024
@jepemi @MiguelCompany
Fix wrong log info messages on TCP (#4258)
3813aa3 
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
(cherry picked from commit 36f7f57)

# Conflicts:
#	src/cpp/rtps/transport/TCPTransportInterface.cpp
MiguelCompany pushed a commit that referenced this pull request Feb 14, 2024
@mergify @jepemi
Fix wrong log info messages on TCP (#4258) (#4312)
5225888 
* Fix wrong log info messages on TCP (#4258)

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
(cherry picked from commit 36f7f57)

# Conflicts:
#	src/cpp/rtps/transport/TCPTransportInterface.cpp

* Refs #20262: Resolve conflicts

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

---------

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
Co-authored-by: Jesús Pérez <78275223+jepemi@users.noreply.github.com>
Co-authored-by: Jesus Perez <jesusperez@eprosima.com>
EduPonz pushed a commit that referenced this pull request Feb 15, 2024
@jepemi @EduPonz
Fix wrong log info messages on TCP (#4258)
cf663eb 
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
(cherry picked from commit 36f7f57)

# Conflicts:
#	src/cpp/rtps/transport/TCPTransportInterface.cpp
EduPonz pushed a commit that referenced this pull request Feb 16, 2024
@mergify @jepemi
Fix wrong log info messages on TCP (#4258) (#4313)
b31ceda 
* Fix wrong log info messages on TCP (#4258)

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
(cherry picked from commit 36f7f57)

# Conflicts:
#	src/cpp/rtps/transport/TCPTransportInterface.cpp

* Refs #20262: Resolve conflicts

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

---------

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
Co-authored-by: Jesús Pérez <78275223+jepemi@users.noreply.github.com>
Co-authored-by: Jesus Perez <jesusperez@eprosima.com>
EduPonz pushed a commit that referenced this pull request Feb 16, 2024
@mergify @jepemi
Fix wrong log info messages on TCP (#4258) (#4311)
6b4b4cf 
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
(cherry picked from commit 36f7f57)

Co-authored-by: Jesús Pérez <78275223+jepemi@users.noreply.github.com>
jepemi added a commit that referenced this pull request Feb 23, 2024
@jepemi
Fix wrong log info messages on TCP (#4258)
6738dd8 
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
(cherry picked from commit 36f7f57)

# Conflicts:
#	src/cpp/rtps/transport/TCPTransportInterface.cpp
EduPonz pushed a commit that referenced this pull request Mar 6, 2024
@mergify @jepemi
Fix wrong log info messages on TCP (#4258) (#4314)
89b4f17 
* Remove unnecessary warning (#4217)

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
(cherry picked from commit ab94226)

* Fix wrong log info messages on TCP (#4258)

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
(cherry picked from commit 36f7f57)

# Conflicts:
#	src/cpp/rtps/transport/TCPTransportInterface.cpp

* Refs #20262: Resolve conflicts

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

---------

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
Co-authored-by: Jesús Pérez <78275223+jepemi@users.noreply.github.com>
Co-authored-by: Jesus Perez <jesusperez@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.13.2
Development

Successfully merging this pull request may close these issues.
4 participants
@jepemi @EduPonz @MiguelCompany @JesusPoderoso