Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20176] Downgrade cmake version #4218

Merged
merged 4 commits into from
Jan 10, 2024
Merged

[20176] Downgrade cmake version #4218

merged 4 commits into from
Jan 10, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Jan 9, 2024 •
edited
Loading

Description

Reduce CMake minimum version required for Fast DDS compatibility against RHEL 9.

@Mergifyio backport 2.12.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso
Refs #20176: downgrade cmake version
ce663b9 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso added the skip-ci Automatically pass CI label Jan 9, 2024
@JesusPoderoso JesusPoderoso added this to the v2.13.1 milestone Jan 9, 2024
@JesusPoderoso
Refs #20176: Require CMake minimum version 3.22 only for tests
e60ab46 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso force-pushed the feature/downgrade_cmake_version branch from 5216f8f to e60ab46 Compare January 9, 2024 13:44
@JesusPoderoso
Refs #20176: Move test requirement to common function
99651b6 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
EduPonz
EduPonz suggested changes Jan 10, 2024
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed CustomPayloadPoolExample

@JesusPoderoso
Refs #20176: Apply rev suggestions
698250a 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@EduPonz EduPonz merged commit 69b3e6a into master Jan 10, 2024
8 checks passed
@EduPonz EduPonz deleted the feature/downgrade_cmake_version branch January 10, 2024 07:54
@JesusPoderoso
Copy link
Contributor Author

@Mergifyio backport 2.12.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 11, 2024 •
edited
Loading

backport 2.12.x

✅ Backports have been created

@mergify mergify bot mentioned this pull request Jan 11, 2024
Merged
JesusPoderoso added a commit that referenced this pull request Jan 11, 2024
@JesusPoderoso
Downgrade CMake minimum version to 3.20 (#4218)
dceb61f 
* Refs #20176: downgrade cmake version

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #20176: Require CMake minimum version 3.22 only for tests

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #20176: Move test requirement to common function

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #20176: Apply rev suggestions

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 69b3e6a)
EduPonz pushed a commit that referenced this pull request Jan 12, 2024
@mergify @JesusPoderoso
Downgrade CMake version to 3.20 (#4218) (#4232)
cead422 
* Downgrade CMake minimum version to 3.20 (#4218)

* Refs #20176: downgrade cmake version

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #20176: Require CMake minimum version 3.22 only for tests

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #20176: Move test requirement to common function

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #20176: Apply rev suggestions

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 69b3e6a)

* Refs #20176: Update Fast CDR submodule up to v2.1.3

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@duca duca mentioned this pull request Jan 25, 2024
Closed
@elianalf elianalf mentioned this pull request Mar 5, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
first-to-merge skip-ci Automatically pass CI
Projects
None yet
Milestone
v2.13.1
Development

Successfully merging this pull request may close these issues.
2 participants
@JesusPoderoso @EduPonz