Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DNS filter in CMakeLists file #4211

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

Tempate
Copy link
Contributor

@Tempate Tempate commented Jan 8, 2024

Description

In the previous version, the DNS Filter tests were not being compiled when the tag EPROSIMA_TEST_DNS_NOT_SET_UP was set.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • NA Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • NA Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • NA New feature has been added to the versions.md file (if applicable).
  • NA New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: tempate <danieldiaz@eprosima.com>
@Tempate Tempate added the no-test Skip CI tests if PR marked with this label label Jan 8, 2024
@EduPonz EduPonz added this to the v2.13.2 milestone Jan 9, 2024
@EduPonz EduPonz merged commit 5aa169c into master Jan 9, 2024
14 checks passed
@EduPonz EduPonz deleted the hotfix/dns_filter_cmake branch January 9, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-test Skip CI tests if PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants